Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IN-346][Reviews] Show preprintDoiUrl if it exists #146

Open
wants to merge 1 commit into
base: release/next-interfaces
Choose a base branch
from
Open

[IN-346][Reviews] Show preprintDoiUrl if it exists #146

wants to merge 1 commit into from

Conversation

mfraezz
Copy link
Member

@mfraezz mfraezz commented Aug 14, 2018 •
edited by fabmiz
Loading

Purpose

Fix preprintDoiUrl display logic.

Summary of Changes/Side Effects

  • If the url is there, show it
  • If not, and it's published, show the "being minted" language
  • Otherwise, show the "publish this to make a DOI" language

Testing Notes

Ticket details steps to reproduce

Ticket

[IN-346]

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md

@mfraezz mfraezz force-pushed the feature/346-acc-rej-doi branch from a0a7509 to b6f25a3 Compare August 14, 2018 14:51
@coveralls
Copy link

coveralls commented Aug 14, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 56.927% when pulling 35eaa11 on mfraezz:feature/346-acc-rej-doi into 76aeec7 on CenterForOpenScience:release/next-interfaces.

@alexschiller alexschiller changed the title [IN-346] Show preprintDoiUrl if it exists [IN-346][Reviews] Show preprintDoiUrl if it exists Aug 21, 2018
@mfraezz mfraezz force-pushed the feature/346-acc-rej-doi branch from b6f25a3 to 35eaa11 Compare August 21, 2018 20:57
fabmiz
fabmiz approved these changes Aug 21, 2018
View reviewed changes
Copy link
Member

@fabmiz fabmiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabmiz fabmiz fabmiz approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfraezz @coveralls @fabmiz