Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

docs: Remove workarounds from example.ks #72

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

poncovka
Copy link
Contributor

The partitioning defined in the example kickstart file suggests that the
installer supports hybrid boot. That's misleading and not true. Let's use
the reqpart kickstart command to automatically create partitions required
by the detected platform instead of creating all of them for all platforms.

Note: The reqpart command doesn't work with bootloader --location=none or
bootloader --disabled, so this change depends on the installer's support
for bootupd.

Depends on: rhinstaller/anaconda#5298

@rhatdan
Copy link
Collaborator

rhatdan commented Dec 6, 2023

@cgwalters Thoughts?

@cgwalters
Copy link
Member

I was thinking we'd merge this after an Anaconda ISO was generated; looks like
https://src.fedoraproject.org/rpms/anaconda/blob/rawhide/f/anaconda.spec#_476
just happened and should probably be in https://odcs.fedoraproject.org/composes/production/latest-Fedora-ELN/compose/BaseOS/x86_64/iso/
so we should give that a spin

Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confimed this works, thanks.

However I discovered a non-blocking followup issue to address rhinstaller/anaconda#5363

docs/example.ks Outdated Show resolved Hide resolved
@cgwalters cgwalters marked this pull request as ready for review December 13, 2023 16:43
@cgwalters
Copy link
Member

Gah, the trailing whitespace check is annoying

@lmilbaum
Copy link
Contributor

lmilbaum commented Dec 14, 2023

Gah, the trailing whitespace check is annoying

:-) It is.
Few options:

  1. Install pre-commit locally. It will report and fix the error before the commit is done.
  2. Disable this specific check. The issue is that it will apply to all files in the repo. GitHub shows a red sign when it is missing.
  3. Use IDE plugin which adds the white space automatically when saving the file

poncovka and others added 3 commits December 15, 2023 16:01
The installer supports bootupd now, so we can drop the workaround.
See: rhinstaller/anaconda#5298
The partitioning defined in the example kickstart file suggests that the
installer supports hybrid boot. That's misleading and not true. Let's use
the `reqpart` kickstart command to automatically create partitions required
by the detected platform instead of creating all of them for all platforms.

Note: The `reqpart` command doesn't work with `bootloader --location=none` or
`bootloader --disabled`, so this commit depends on the installer's support
for bootupd: rhinstaller/anaconda#5298
The kickstart file works with a Fedora 40+ (or ELN) installer ISO as
it requires rhinstaller/anaconda#5342.

Co-authored-by: Colin Walters <[email protected]>
@poncovka
Copy link
Contributor Author

Updated. I run locally pre-commit run --all-files and it passed, so hopefully, it is fine now.

Copy link
Collaborator

@sallyom sallyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit green,
LGTM

@cgwalters cgwalters merged commit 948f774 into CentOS:main Dec 15, 2023
1 of 2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants