Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common command line parser #1100

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

common command line parser #1100

wants to merge 5 commits into from

Conversation

375gnu
Copy link
Member

@375gnu 375gnu commented Jul 4, 2021

@levinli303 what do you think about this? my attempt is to remove copy-pasted command line parsing and keep the its common part to celestiacore. it's tested with qt/gtk/win. not finished yet. i want to hear your feedback. it also contains some tiny unrelated changes i will file them as separate prs.

@levinli303
Copy link
Collaborator

since my frontends do not really accept command line arguments, im fine with the changes as long as we still expose interfaces to load from specific .cfg and extra dirs.

Also I wonder if we can move away from current directory to load from, would it make sense for all files to be loaded according to an absolute path?

@375gnu
Copy link
Member Author

375gnu commented Jul 8, 2021

Also I wonder if we can move away from current directory to load from, would it make sense for all files to be loaded according to an absolute path?

We can use absolute paths in many (or even all) places of celestia.cfg. Or do you mean something else?

@levinli303
Copy link
Collaborator

I'm saying now (on my frontends), I need to call chdir (or similar APIs) to change working directory so the relative path in data files in cfg can be correctly loaded. is it possible to avoid it. (maybe store a value of the root path for relative paths to load from?)

@375gnu
Copy link
Member Author

375gnu commented Jul 9, 2021

chdir approach is much simpler, in this pr i want to move it to CelestiaCore

@375gnu 375gnu marked this pull request as draft July 17, 2021 13:44
@375gnu 375gnu force-pushed the master branch 2 times, most recently from 690ab56 to 2f8f3b0 Compare May 15, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants