Datto REST API - SaaS Bulk Seat Change

[cksapp]

Pull Request

Datto SaaS Protection - Bulk Seat Change REST API Function

Description

Fixes SaaS Bulk Seat Assignment Function added in 5cabe17 to support API endpoint.

Resolves: #2 [Bug]: SaaS Bulk Seat Update Endpoint should be SET with PUT call.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• General code cleanup (non-breaking change which improves readability)

Checklist

• I have reviewed the Contributing guide
• I am pulling to the dev branch
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

How Has This Been Tested?

Validated against expected behavior from API calls via Postman, changes were reflected in the Datto SaaS Protection service.

• Postman

• Before
  
• Postman API call
  
• Result
  

---

• PowerShell Wrapper Module

• Before
  
• PowerShell Function
  
• Result
  

[Celerium]

@cksapp, Thank you for the awesome contrubutions! Mostly everything looks good here so I am going to merge and make some tweaks to a few items.

#2

[cksapp]

Thanks @Celerium! I actually meant to also push a minor commit in 12f5790 as part of this, not anything major so otherwise the function works just as intended. Mainly updating the messaging and examples, not sure if the PR can be amended after being closed or it would require another pull request.

Otherwise feel free to simply copy the changes from there, and feel free to make any changes overall as you see fit for the module.
Glad to contribute 😄

[Celerium]

No worries, ill add those updates as well. I also found some other changes that Datto made to their API that ill be adding as well.

For the actionType where did you find the values of 'License', 'Pause', 'Unlicense'? I cant seem to find them in their API docs

[cksapp]

No worries, ill add those updates as well. I also found some other changes that Datto made to their API that ill be adding as well.

Okay great, there were a few additional things I noticed in the docs that may have been missed or need to be updated so might try to work on another small PR to update those when I can.
I did notice the new additions to seats API as well but hadn't had a chance to review further.

---

For the actionType where did you find the values of 'License', 'Pause', 'Unlicense'? I cant seem to find them in their API docs

Regarding the actionType, I have to agree the documentation for the API is fairly sparse to say the least. Mostly determining the actionType was based on trial and error, as well as just a bit of insider knowledge.
(I currently work within Datto's SaaS Protection product and scoured for information internally based on the changes from their dev team as no-one else was familiar). 😉

There does not appear to be any other mentions of additional actionTypes and testing with an actionType of something like Archive does not appear to accept any PUT and simply returns,

{
    "code": "error.internal",
    "message": "An internal server error occurred"
}

On a side note to this, I do strongly believe we should make the note that both actionType, and seatType are case-sensitive and otherwise appear to require PascalCase as the call will return an error if not respected.

I presume this is due to the *NIX backend systems being used. I am not sure if we could/should enforce the case-sensitivity for the input, or simply return the error and make the warning in the docs here.
We probably could, but as an API wrapper I feel its best to let most of the logic be handled by the module user