Adding default-tls and rustls-tls features #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
don't merge .. yet. more work needs to be done before merge |
|
OK to merge @Celeo |
|
Sounds good! I made some small changes; no affect on the actual implementation details. Thanks for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating two features:
default-tls: uses OpenSSL as the reqwest backend to send and recieve all requests. Enabled by default (this was the default behavior until now).
rustls-tls: Uses rustls as the reqwest backend to send and recieve all requests.
adding a small validation top avoid enabling both features at the same time (this could me better in a more elegant way, but for now its Ok)
Reason to do this: Avoid using unsafe code.