Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt CEF version 115+ #311

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Adapt CEF version 115+ #311

merged 1 commit into from
Sep 3, 2023

Conversation

tishion
Copy link
Member

@tishion tishion commented Sep 3, 2023

Adapt CEF Version 115+

  • Remove user data path from QCefConfig when compiling with CEF 115+
  • Add root cache path to QCefConfig when compiling with CEF 115+

@tishion tishion requested a review from L-Super September 3, 2023 04:39
@tishion
Copy link
Member Author

tishion commented Sep 3, 2023

@L-Super please take a look at this PR and you can close #310

@tishion tishion changed the title Adapt CEF versionn 115+ Adapt CEF version 115+ Sep 3, 2023
L-Super
L-Super approved these changes Sep 3, 2023
View reviewed changes
Copy link
Member

@L-Super L-Super left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@L-Super L-Super merged commit ce4b07f into main Sep 3, 2023
@tishion tishion deleted the feature/adapt-cef-115 branch September 23, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-Super L-Super L-Super approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tishion @L-Super