Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed CefEnableHighDPISupport function on higer version #239

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Removed CefEnableHighDPISupport function on higer version #239

merged 1 commit into from
Apr 27, 2023

Conversation

L-Super
Copy link
Member

@L-Super L-Super commented Apr 26, 2023

see cef#3452

@tishion
Copy link
Member

tishion commented Apr 26, 2023

感谢你的提交!
Core的PR已经合并了,接下来,可否进行如下操作?
1.再发一条Core的PR, 把CEF的版本升级到112?

2.等待1的PR合并后,再把当前这个PR内的Core的submodule升级到最新的Core?

然后我会一起合并这个PR,这样可以吗?

@L-Super
Copy link
Member Author

L-Super commented Apr 26, 2023

感谢你的提交!
Core的PR已经合并了,接下来,可否进行如下操作?
1.再发一条Core的PR, 把CEF的版本升级到112?

2.等待1的PR合并后,再把当前这个PR内的Core的submodule升级到最新的Core?

然后我会一起合并这个PR,这样可以吗?

CEF升级指的是CMake的set(CEF_SDK_VERSION)这里吗?添加新的版本注释?

@tishion
Copy link
Member

tishion commented Apr 26, 2023

感谢你的提交!
Core的PR已经合并了,接下来,可否进行如下操作?
1.再发一条Core的PR, 把CEF的版本升级到112?

2.等待1的PR合并后,再把当前这个PR内的Core的submodule升级到最新的Core?

然后我会一起合并这个PR,这样可以吗?

CEF升级指的是CMake的set(CEF_SDK_VERSION)这里吗?添加新的版本注释?

是的,把现在的版本注释掉(不要删除),然后把新版本添加进去,如果构建失败的话我抽空看。

@tishion tishion merged commit a66ef7a into CefView:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants