Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt cef 106 #160

Closed
wants to merge 6 commits into from
Closed

Adapt cef 106 #160

wants to merge 6 commits into from

Conversation

HO-COOH
Copy link
Contributor

@HO-COOH HO-COOH commented Oct 16, 2022

I adapted cef 106, so now the project can be built with latest cef 106 binary. Two breaking changes from cef are:

  1. Add CefBaseTime and use it instead of CefTime (see issue #2935) Cef commit hash 27d308980414432ee69bdc16dae7cb16a6aaa2b9
  2. Delete cef_web_plugin.h and plugin-related APIs (see issue #3047) Cef commit hash 28c7f040016a0271ec2612cc5021599fb55a1054

@tishion
Copy link
Member

tishion commented Oct 17, 2022

@HO-COOH Thank you for your work. The code looks very good! But you meed to update the CEF version in QCefViweCore and submit PR to that project first. Then you just update the sub module in project QCefView and submit PR to this project.

@HO-COOH
Copy link
Contributor Author

HO-COOH commented Oct 17, 2022

This workaround would require a modification in CefConfig.cmake file of the CefViewCore project that parses the cef version macro. Please tell me whether this approach is acceptable.

@tishion
Copy link
Member

tishion commented Oct 25, 2022

move to #167

@tishion tishion closed this Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants