Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RA modification patches to transpilers #30

Closed
wants to merge 2 commits into from

Conversation

Axwabo
Copy link

@Axwabo Axwabo commented Mar 12, 2023

Harmony prefixes are an easy way to modify a method but may prevent others from further modifying it.

Converted the following patches to transpilers:

  • RaPlayerListPatch
  • RaPlayerPatch
  • RaPlayerAuthPatch

This enables other developers to patch the methods.

@moddedmcplayer
Copy link
Member

just so you know you're gonna be the one maintaining them or they'll just become prefixes again next time this changes lmao xd

@ced777ric
Copy link
Member

And this has all been tested?

@Axwabo
Copy link
Author

Axwabo commented Mar 13, 2023

Can confirm that all modified features work:

image
image

Copy link
Member

@ced777ric ced777ric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts, idk how the transpilers do their thing so im not gonna touch it for now

@Misaka-ZeroTwo
Copy link

just so you know you're gonna be the one maintaining them or they'll just become prefixes again next time this changes lmao xd

get good and learn how it works XD

@moddedmcplayer
Copy link
Member

just so you know you're gonna be the one maintaining them or they'll just become prefixes again next time this changes lmao xd

get good and learn how it works XD

no

@ced777ric ced777ric closed this Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants