Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small refactorings #2595

Merged
merged 2 commits into from
Nov 28, 2024
Merged

small refactorings #2595

merged 2 commits into from
Nov 28, 2024

Conversation

lbownik
Copy link
Contributor

@lbownik lbownik commented Nov 27, 2024

Small refactorings here and there

@lbownik lbownik requested a review from diasf November 27, 2024 16:41
@lbownik lbownik assigned diasf and unassigned diasf Nov 27, 2024
@@ -336,6 +337,14 @@ public DatasetVersion getLatestVersionForCopy() {
public List<DatasetVersion> getVersions() {
return versions;
}

public Dataverse getRoot() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: IMHO it would fit better in Dataverse

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@diasf diasf assigned lbownik and unassigned lbownik Nov 28, 2024
@lbownik lbownik merged commit e7849d1 into develop Nov 28, 2024
1 check passed
@lbownik lbownik deleted the refactorings branch November 28, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants