Closes #2590 - Deleted users makes it impossible to download CSV cont… #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbownik
force-pushed
the
2590_deleted_user_makes_it_impossible_to_download_CSV
branch
from
2ed2460 to
8fba0a3
Compare
diasf
reviewed
Nov 26, 2024
| @@ -27,8 +27,13 @@ public class DashboardUserInfoService { | |||
| public List<DashboardUserInfo> createDashboardUsers(UserListResult userListResult) { | |||
| List<DashboardUserInfo> userInfoList = new LinkedList<>(); | |||
| for (AuthenticatedUser user : userListResult.getUserList()) { | |||
| userInfoList.add(new DashboardUserInfo(user, getAuthProviderFriendlyName(user), | |||
| hasSelectedConfirmedEmail(user), getUserNotificationLanguageDisplayName(user, session.getLocale()))); | |||
| if (!user.isErased()) { | |||
There was a problem hiding this comment.
Not sure this is the best place to filter. What about counters, are they still correct? I would have guessed that UserServiceBean or queries in AuthenticatedUser would be a better place to filter out erased accounts in order have a more consistent impact.
| @@ -40,7 +40,9 @@ public void write(OutputStream outputStream, List<AuthenticatedUser> authenticat | |||
|
|
|||
| csvPrinter.printRecord(AuthenticatedUserCSVRecord.getHeaders()); | |||
| for(AuthenticatedUser user : authenticatedUsers) { | |||
| csvPrinter.printRecord(buildRecord(user).getValues()); | |||
| if(! user.isErased()) { | |||
There was a problem hiding this comment.
Same as above, this seems to be the wrong place to filter out records.
added 2 commits
November 27, 2024 09:55
…aining users' list
lbownik
force-pushed
the
2590_deleted_user_makes_it_impossible_to_download_CSV
branch
from
e4d33aa to
922bacd
Compare
lbownik
deleted the
2590_deleted_user_makes_it_impossible_to_download_CSV
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aining users' list