Fixed "Failed to delete temp like" in IngestableDataChecker under Win… #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diasf
reviewed
Nov 14, 2024
| } | ||
|
|
||
| @AfterEach | ||
| public void tearDown() { | ||
| private AbstractStringAssert<?> assertThatADATA(final String content) |
There was a problem hiding this comment.
Why ADATA? Maybe better naming would be assertThatDATFormat?
| } | ||
|
|
||
| private AbstractStringAssert<?> assertThatSAV(final String content) |
There was a problem hiding this comment.
Analogous to above would suggest assertThatSAVFormat?
| return buff; | ||
| } | ||
| @Test | ||
| public void testingADATA_returnsMimeType_forProperContent() throws Exception { |
There was a problem hiding this comment.
When adding new tests, the convention for test methods is to start with the method being tested as prefix, eg testDTAformat_returnsMimeType_forProperContent. Check methods below as well.
added 2 commits
November 14, 2024 13:05
diasf
reviewed
Nov 14, 2024
| } | ||
|
|
||
| private AbstractStringAssert<?> assertThatADATAFormat(final String content) |
There was a problem hiding this comment.
There's still ADATA instead of DTA in the name.
| private void msg(String m) { | ||
| System.out.println(m); | ||
| @Test | ||
| public void testADATAformat_returnsMimeType_forProperContent() throws Exception { |
There was a problem hiding this comment.
There's still ADATA instead of DTA in the name.
| assertEquals(result, "application/x-stata-13"); | ||
|
|
||
|
|
||
| public void testingSAVformat_returnsMimeType_forProperContent() throws Exception { |
| msg("result 2c: " + result); | ||
| assertEquals(result, null); | ||
|
|
||
| public void testingSAVformat_returnsNull_forBrokenContent() throws Exception { |
…tableDataCheckerTest
lbownik
deleted the
fixed_failed_to_delete_temp_file_in_IngestableDataCheckerTest
branch
diasf
reviewed
Nov 20, 2024
| private void msg(String m) { | ||
| System.out.println(m); | ||
| @Test | ||
| public void testADATAformat_returnsMimeType_forProperContent() throws Exception { |
There was a problem hiding this comment.
You missed to change ADATA in the method name before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored IngestableDataChecker to use generic ByteBuffer.
Refactored test to use in-momory buffers instaed of memory-mapped temporaty files.