Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2567 flaky it tests #2574

Merged
merged 38 commits into from
Oct 23, 2024
Merged

Closes #2567 flaky it tests #2574

merged 38 commits into from
Oct 23, 2024

Conversation

diasf
Copy link
Contributor

@diasf diasf commented Oct 22, 2024

Reasons for flakiness:

  • Async indexing, solr didn't yet index all documents before tests started already querying it
  • Non-atomic filesystem operations (file deletion not yet observable before checking absence)
  • Async mail notifications
  • Jenkins specific: Test containers (solr & postgres) are started for both dataverse-persistence and dataverse-webapp in the same docker network. The test containers are only stopped and removed at the end of the verify maven lifecylce. This means that during the execution of dataverse-webapp integration tests, there are 2 solr and 2 postgres containers running with the same DNS name respectively. Less of a problem with postgres as tests rollback their transactions. But for solr this caused some issues as the solrclient, when sending requests to http://solr:8983, was getting responses from one or the other container. To circumvent this, the 2 test containers are now started before verify and then cleaned up when verify finishes.

Issue: #2567

@diasf diasf self-assigned this Oct 22, 2024
@diasf diasf assigned JakubNejmanICM and unassigned diasf Oct 22, 2024
@diasf diasf merged commit b0eaed8 into develop Oct 23, 2024
1 check passed
@diasf diasf deleted the fdias-2567-flaky-IT-tests branch October 23, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants