Closes #2460: Compatibility with libre office files #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madryk
approved these changes
May 16, 2024
|
|
||
| // then | ||
| assertThat(result.getDataTable().getVarQuantity()).isEqualTo(5); | ||
| assertThat(result.getDataTable().getDataVariables().stream().map(DataVariable::getName).collect(Collectors.toList())) |
There was a problem hiding this comment.
Not a change request.
We could have also write it in a little shorter way:
`assertThat(result.getDataTable().getDataVariables()).extracting(DataVariable::getName)
There was a problem hiding this comment.
Oh yeah, that's much better. Changed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make xslx reader compatible with files created by libre office.
Handled issues:
rId1). However the id of a sheet is configurable and can be set as desired by applications creating the xslx. In this case excel starts sheet ids with rId1, rId2, ... whereas libre starts atrId2. The fix usesgetSheetDatato just fetch the first sheet.spansattribute for each row indicating how many columns it contains. This was used to allocate an array for the column names. Unfortunately, libre office doesn't include this attribute. The fix replaces the array with aTreeMapallowing to collect the column names as we parse them.Issue: #2460