Skip to content
This repository has been archived by the owner on Mar 15, 2021. It is now read-only.

WIP: Update library path for new versions of OBS #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: Update library path for new versions of OBS #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ endif()
set_target_properties(v4l2sink PROPERTIES PREFIX "")

install(TARGETS v4l2sink
LIBRARY DESTINATION ${CMAKE_INSTALL_PREFIX}/lib/obs-plugins)
LIBRARY DESTINATION ${CMAKE_INSTALL_PREFIX}/lib/x86_64-linux-gnu/obs-plugins)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks incorrect as this hardcode the libdir for x86_64 and is a debianism. (others distro don't use this scheme).

Usually CMAKE_INSTALL_LIBDIR needs to be configured as appropriate. Or this should be inherited from FindLibObs.cmake (from the obs-studio devel package)...

Copy link

@kwizart kwizart Feb 14, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not a project maintainer).


install(DIRECTORY locale/
DESTINATION "${CMAKE_INSTALL_PREFIX}/share/obs/obs-plugins/v4l2sink/locale")
Expand Down