This repository has been archived by the owner on Mar 15, 2021. It is now read-only.
WIP: Update library path for new versions of OBS #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't that break non ubuntu users? |
|
It doesn't break for Debian necessarily, but good point about other distros. Plus, there's other architectures too that don't use that. I'll just leave this PR open for now and revise it after later research. |
josephgeis
changed the title
|
CMake should be picking that path up. Take a look at the GNUInstallDirs module. |
kwizart
reviewed
Feb 14, 2021
| @@ -44,7 +44,7 @@ endif() | |||
| set_target_properties(v4l2sink PROPERTIES PREFIX "") | |||
|
|
|||
| install(TARGETS v4l2sink | |||
| LIBRARY DESTINATION ${CMAKE_INSTALL_PREFIX}/lib/obs-plugins) | |||
| LIBRARY DESTINATION ${CMAKE_INSTALL_PREFIX}/lib/x86_64-linux-gnu/obs-plugins) | |||
There was a problem hiding this comment.
This looks incorrect as this hardcode the libdir for x86_64 and is a debianism. (others distro don't use this scheme).
Usually CMAKE_INSTALL_LIBDIR needs to be configured as appropriate. Or this should be inherited from FindLibObs.cmake (from the obs-studio devel package)...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86