-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAINTROID-634 : Add Eraser tool #31
Conversation
a63a02c
to
609fe81
Compare
df99ede
to
4ca1a92
Compare
final bgPicture = backgroundRecorder.endRecording(); | ||
final bgImage = await bgPicture.toImage( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would write the whole name like you did with the others
backgroundPicture
backgroundImage
Also those 2 are synonyms, maybe specify what makes them different in the name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored the function, it should be more readable now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments, looks good to me though!
4ca1a92
to
df2ff74
Compare
df2ff74
to
fddbb2a
Compare
PAINTROID-634
PAINTROID-533
PAINTROID-646
New Features and Enhancements
false
to stay consistent with Paintroid-Kotlin.Refactorings and Bug Fixes
Checklist