Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAINTROID-453 : Flutter: Add Brush Options #27

Merged
merged 1 commit into from
Jul 21, 2023
Merged

PAINTROID-453 : Flutter: Add Brush Options #27

merged 1 commit into from
Jul 21, 2023

Conversation

bakicelebi
Copy link
Contributor

@bakicelebi bakicelebi commented Jul 4, 2023 •
edited
Loading

PAINTROID-453

Added top and bottom brush tool options. Added a new provider for brush tool paint properties.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

@bakicelebi bakicelebi force-pushed the PAINTROID-453 branch 7 times, most recently from 6b9120e to a316558 Compare July 14, 2023 15:37
juliajulie95
juliajulie95 reviewed Jul 16, 2023
View reviewed changes
Copy link
Contributor

@juliajulie95 juliajulie95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
I left some comments on things we may change

@bakicelebi
Copy link
Contributor Author

Thank you! Changed the requested lines 👍

@juliajulie95
Copy link
Contributor

It's currently possible to set the paint size to 0 (and it still paints) we should limit this to minimum of 1

@juliajulie95 juliajulie95 merged commit 2af2306 into Catrobat:develop Jul 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliajulie95 juliajulie95 juliajulie95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bakicelebi @juliajulie95