Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAINTROID-782 : Use file picker for choosing file saving location #106

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Nithish-Sri-Ram
Copy link

@Nithish-Sri-Ram Nithish-Sri-Ram commented Jan 2, 2025

Please enter a short description of your pull request and add a reference to the Jira ticket.

New Features and Enhancements

  • Integrated file_picker package to allow users to choose a directory for saving images or projects.
  • Added functionality to prompt users with a directory picker when saving.
  • Updated image metadata handling to include the selected directory path, replacing the default emulated storage behavior.
    Improved user experience by offering flexibility and control over file-saving locations.
782.mp4

782

Refactorings and Bug Fixes

  • Adjusted _dismissDialogWithData logic to support file picker integration.
  • Refactored image saving logic to ensure compatibility with new directory selection.

Checklist

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Add the link to the ticket in Jira in the description of the PR
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines (Wiki)
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Add new information to the Wiki

@bakicelebi
Copy link
Contributor

Hi @Nithish-Sri-Ram this is a Native Kotlin ticket. Please align with @juliajulie95 first before continuing this ticket. Anyway opening a file picker everytime an image is saved is not the best for the user experience. I would suggest to add a section in the save image dialog for selecting a custom save path instead of the default.

@Nithish-Sri-Ram
Copy link
Author

@bakicelebi , I’ve implemented your suggestions and updated the functionality to allow users to save both images and projects to the specified path. @juliajulie95 , please review the changes and share your feedback.

Saved.to.default.path.mp4

@juliajulie95
Copy link
Contributor

I'll have a look in the next days

@Nithish-Sri-Ram
Copy link
Author

Sure Okay 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants