-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAINTROID-490: Search bar on Landing Page #105
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Good work!
Functionality wise it looks really good, nice job!
Some points:
- The landing page uses setState for state management, which was likely the initial implementation approach. Since we now use Riverpod throughout the app, refactoring the landing page to use Riverpod would improve consistency and could be a fun challenge.
- We are striving to work with TDD (Test-Driven Development) as much as possible. I understand that it’s not always easy to strictly adhere to TDD. In cases where it is not feasible, please make sure to add new widget tests or integration tests afterward, especially for new implementations.
If you got any questions feel free to tag me or other contributors! Cheers 🌞
Thank you for the feedback! I wanted to ensure the feature in this PR meets expectations before proceeding further with adding tests. Appreciate your guidance! |
Merging feat/search_bar_sorting to develop branch
I have merged PR #107 to the current PR |
I am working on writing test files |
Added comprehensive test coverage for:
All tests are passing. Please let me know if any changes are needed! |
Ticket
JIRA Ticket - PAINTROID-490
Flutter: Search bar on Landing Page
This PR introduces a search functionality to the LandingPage that allows users to search for projects by name. The search feature includes a search toggle button and a search text field. When the search button is pressed, it hides the ProjectPreview and focuses on just the list of projects. The FloatingActionButton also hides as we go into search mode.
New Features and Enhancements
Added search bar functionality to search projects by name
Changes
Added
SearchToggleButton
Component:SearchToggleButton
component that toggles between a search icon and a close icon based on the search state.Added
SearchTextField
Component:SearchTextField
component that provides a text input field for users to enter their search queries.Updated
LandingPage
to Integrate Search Functionality:LandingPage
component.SearchToggleButton
andSearchTextField
components into theAppBar's title
of theLandingPage
.LandingPage
to hideProjectPreview
andFloatingActionButton
when in search mode.Refactorings and Bug Fixes
n-1
projects were displayed whenn
projects were saved.Removed unnecessary
index != 0
condition to ensure all saved projects are visible.catrobat.mov
Checklist
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.