Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATTY-727 Implement minimal functionallity for SVG Plot creation #1838

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

StofflR
Copy link
Contributor

@StofflR StofflR commented Jun 17, 2024

Implement minimal functionallity for SVG Plot creation
https://jira.catrob.at/browse/CATTY-727

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Verify that the Jira ticket is in the status Ready for Development
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #catty Slack channel and ask for a code reviewer

Added basic functionality for basic svg creation for plotter

  • start plot
  • stop plot
  • save plot to svg
    Fixed PenUp/PenDown bug
  • separate arrays on penUp to retain the needed information

Copy link
Contributor

@lucatp lucatp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schaut so weit schon sehr gut aus, hab paar Sachen die man verbessern könnte dazu geschrieben.

Copy link
Contributor

@wallisch wallisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased on latest develop and corrected the swiftlint issues, can you please address the remaining comments?

@wallisch wallisch merged commit 107de90 into Catrobat:develop Oct 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants