-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CATTY-727 Implement minimal functionallity for SVG Plot creation #1838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Schaut so weit schon sehr gut aus, hab paar Sachen die man verbessern könnte dazu geschrieben.
src/Catty/Extension&Delegate&Protocol/Extensions/SpriteNode/CBSpriteNodePenExtension.swift
Outdated
Show resolved
Hide resolved
src/Catty/Extension&Delegate&Protocol/Extensions/SpriteNode/CBSpriteNodePenExtension.swift
Outdated
Show resolved
Hide resolved
src/Catty/Extension&Delegate&Protocol/Extensions/SpriteNode/CBSpriteNodePenExtension.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased on latest develop and corrected the swiftlint issues, can you please address the remaining comments?
Implement minimal functionallity for SVG Plot creation
https://jira.catrob.at/browse/CATTY-727
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.
Added basic functionality for basic svg creation for plotter
Fixed PenUp/PenDown bug