Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATTY-587 Choose image from selected photos #1810

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tom-reith
Copy link
Contributor

JIRA Ticket: (https://jira.catrob.at/browse/CATTY-587)
Bug Description: When the app has limited access to Photos (selected Photos in the settings) sometimes when choosing an image it doesn't get chosen and it is unclear for the user why nothing happened.

Root Cause: In iOS 14, the option for limited access has been added. In the old API (which we use) limited access looks the same as full access (for compatibility reason). See (https://developer.apple.com/documentation/photokit/phauthorizationstatus) for reference.
When trying to read the photo info of a limited file the access is denied. The app doesn't crash but also doesn't ready any data and hence nothing happens in the app.

Solution: Whenever nothing can be read from the image a check is made that verifies the iOS version and the authorizationStatus. If the status is limited a notification is shown if the user wants to change the settings of the app.
Usually, after each app start the app asks automatically to change the settings (but only once). This has been removed as there is now an explicit check for this.

Steps to test:

  1. set photos access to limited in options
  2. navigate to any project -> pick any object -> choose looks
  3. add a new image -> choose image
  4. Pick any image that is not limited -> normal behaviour as always
  5. Pick any image that is restricted -> Notification pops up with the option to change the limited photos selection

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Verify that the Jira ticket is in the status Ready for Development
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #catty Slack channel and ask for a code reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants