Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATTY-643 Show warning for downloaded project that contains Web request bricks #1779

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tom-reith
Copy link
Contributor

@tom-reith tom-reith commented Jan 7, 2023

Description: After the user downloads a project from share, and the project contains a "Send web request" brick, then when the user for the first time opens the project (enters the project in the IDE), a warning notification shall be shown.
There is only an OK button. Once the user pressed that button once, the warning is not shown again.

This warning shall be shown even if the URL is in the list of trusted domains.
This warning shall not be shown for projects created on the user's device.

https://jira.catrob.at/browse/CATTY-643

Changes done:

  • Add new function to check if warning should be shown.
  • Add new text

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Verify that the Jira ticket is in the status Ready for Development
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #catty Slack channel and ask for a code reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants