Merge pull request #1842 from wallisch/CATTY-730

CATTY-730 Fix new Swiftlint warnings

src/Catty/BluetoothDevice/FirmataDevices/Arduino/ArduinoHelper.swift

@@ -32,7 +32,7 @@ open class ArduinoHelper {
     var analogPin4 = 0
     var analogPin5 = 0
 
-    var digitalValues: [Int] = [Int](repeating: 0, count: 21)
+    var digitalValues = [Int](repeating: 0, count: 21)
 
     var portValues = Array(repeating: Array(repeating: 0, count: 8), count: 3)
     //Helper

src/Catty/BluetoothHelper/BluetoothHelper/Components/CentralManager.swift

@@ -208,7 +208,7 @@ import UIKit
 
     open var peripherals: [Peripheral] {
 
-        let values: [Peripheral] = [Peripheral](self.ownPeripherals.values)
+        let values = [Peripheral](self.ownPeripherals.values)
         return values
     }
 

src/Catty/BluetoothHelper/BluetoothHelper/Components/Peripheral.swift

@@ -203,7 +203,7 @@ private func > <T: Comparable>(lhs: T?, rhs: T?) -> Bool {
     }
 
     open var services: [Service] {
-        let values: [Service] = [Service](self.ownServices.values)
+        let values = [Service](self.ownServices.values)
         return values
     }
 

src/Catty/BluetoothHelper/BluetoothHelper/Components/Service.swift

@@ -42,7 +42,7 @@ public final class Service: ServiceWrapper {
 
     // MARK: getter
     public var characteristics: [Characteristic] {
-        let values: [Characteristic] = [Characteristic](self.ownCharacteristics.values)
+        let values = [Characteristic](self.ownCharacteristics.values)
         return values
     }
 

src/Catty/BluetoothHelper/BluetoothHelper/Helper/SimpleFutures.swift

@@ -920,9 +920,10 @@ open class StreamPromise<T> {
 // FutureStream
 open class FutureStream<T> {
 
-    private var futures         = [Future<T>]()
     private typealias InFuture = (Future<T>) -> Void
-    private var saveCompletes   = [InFuture]()
+
+    private var saveCompletes = [InFuture]()
+    private var futures = [Future<T>]()
     private var capacity: Int?
 
     internal let defaultExecutionContext: ExecutionContext = QueueContext.main

src/Catty/BluetoothHelper/BluetoothHelper/Profiles/ProfileManager.swift

@@ -34,7 +34,7 @@ open class ProfileManager {
 
     // PUBLIC
     open var services: [ServiceProfile] {
-        let values: [ServiceProfile] = [ServiceProfile](self.serviceProfiles.values)
+        let values = [ServiceProfile](self.serviceProfiles.values)
         return values
     }
 

src/Catty/BluetoothHelper/BluetoothHelper/Profiles/ServiceProfile.swift

@@ -32,7 +32,7 @@ open class ServiceProfile {
     public let tag: String
 
     open var characteristics: [CharacteristicProfile] {
-        let values: [CharacteristicProfile] = [CharacteristicProfile](self.characteristicProfiles.values)
+        let values = [CharacteristicProfile](self.characteristicProfiles.values)
         return values
     }
 

src/Catty/DataStructures/3rdParty/Stack/CBStack.swift

@@ -52,7 +52,7 @@ class CBStack<T> {
             return
         } else {
             //establish the new item instance
-            let childToUse: LLNode<T> = LLNode<T>()
+            let childToUse = LLNode<T>()
             childToUse.key = key
 
             //set newly created item at the top

src/CattyTests/BluetoothDevices/BluetoothMocks/BluetoothMocks.swift

@@ -31,7 +31,7 @@ class FirmataDelegateMock: FirmataDelegate {
     var receivedString: String = ""
     var receivedPin: Int = 0
     var receivedPort: Int = 0
-    var receivedPortData: [Int] = [Int](repeating: 0, count: 1)
+    var receivedPortData = [Int](repeating: 0, count: 1)
     var receivedValue: Int = 0
     var analogMapping = NSMutableDictionary()
     var capabilityQuery = [[Int: Int]]()

src/CattyTests/PlayerEngine/Functions/ObjectRecognition/ObjectRecognitionFunctionsTest.swift

@@ -26,6 +26,7 @@ import XCTest
 
 class ObjectRecognitionFunctionsTest: XCTestCase {
     private enum SensorType { case x, y, width, height }
+
     var idOfDetectedObjectFunction: IDOfDetectedObjectFunction!
     var objectWithIDVisibleFunction: ObjectWithIDVisibleFunction!
     var labelOfObjectWithIDFunction: LabelOfObjectWithIDFunction!

src/CattyTests/PlayerEngine/Functions/TextRecognition/TextBlockPositionFunctionTest.swift

@@ -26,6 +26,7 @@ import XCTest
 
 class TextBlockPositionFunctionTest: XCTestCase {
     private enum SensorType { case x, y, size }
+
     var textBlockXFunction: TextBlockXFunction!
     var textBlockYFunction: TextBlockYFunction!
     var textBlockSizeFunction: TextBlockSizeFunction!