Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATROID-1479 Test: testFunctionDeletion fails #4660

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

Rawbat
Copy link
Contributor

@Rawbat Rawbat commented Dec 12, 2022

The test was failing because the back button in the formula editor was not set active again after exiting the function menu. I fixed this adding a call to set it active if necessary. Now the behaviour should be as intended and the test passes.

https://jira.catrob.at/browse/CATROID-1479

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

The test was failing because the back button in the formula editor was
not set active again after exiting the function menu. I fixed this
adding a call to set it active if necessary. Now the behaviour should be
as intended and the test passes.
Copy link
Contributor

@reichli reichli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

@reichli reichli merged commit 498a07f into Catrobat:develop Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants