Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVOPS-375 MAINTENANCE Add boolean param. for outgoingNetworkCalls, a… #4583

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

vargmal
Copy link
Contributor

@vargmal vargmal commented Jun 26, 2022

*Add boolean param. for outgoingNetworkCalls.
Add stage for outgoing Network call test in Jenkinsfile.
Change docker file to catrobat-android stable

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.
Add boolean param. for outgoingNetworkCalls add. stage for outgoing Network call test in Jenkinsfile, add change docker file to catrobat-android stable

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

…dd. stage for outgoing Network call test in Jenkinsfile, add change docker file to catrobat-android stable
@wslany wslany merged commit 24737be into Catrobat:develop Jun 27, 2022
@wslany
Copy link
Member

wslany commented Jun 27, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants