Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATROID-1417 Bug fixed where visual placement is skipped #4556

Merged
merged 1 commit into from
Jul 9, 2022

Conversation

dorianpercic
Copy link
Contributor

@dorianpercic dorianpercic commented May 21, 2022

https://jira.catrob.at/browse/CATROID-1417
Added super.onCreate(null) instead of savedInstance -> this will suppress any saved data on create/recreate cycle of an Activity and avoid fragment auto re-creation.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@dorianpercic dorianpercic force-pushed the CATROID-1417 branch 3 times, most recently from b06f6a3 to 9266861 Compare July 5, 2022 18:04
Copy link
Contributor

@Walcho1125 Walcho1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@wslany wslany merged commit e8cfbf8 into Catrobat:develop Jul 9, 2022
@wslany
Copy link
Member

wslany commented Jul 9, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants