Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATROID-1388 Added CLT for Repeat Until Brick #4483

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

moemgva2910
Copy link
Contributor

@moemgva2910 moemgva2910 commented Mar 22, 2022

Wrote a Catrobat Language Test for 'Repeat Until' brick.
https://jira.catrob.at/browse/CATROID-1388

Added CLT since there are currently no tests for this control brick.

Brick Functionality tested:

  • Increment var counter until condition fulfilled.
  • Decrement var counter until condition fulfilled.
  • No increment when condition immediately fulfilled when starting the loop.
  • Increment variables within nested loops where the condition of the outer loop depends on the condition of the inner loop.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

Copy link
Contributor

@Rawbat Rawbat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except that the test takes quite some time because of the added delays. Although the way you implemented it, makes it more understandable while the test runs, these tests are mostly used for automatic checking. So I would argue the display of the counters is not necessary. To make up for this you could seperate the test into multiple sprites if possible. That way the test becomes easier to read.

Copy link
Contributor

@Rawbat Rawbat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

@KarlDerMaisbauer KarlDerMaisbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dorianpercic dorianpercic merged commit 0cdeb2f into Catrobat:develop Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants