Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catroid-1196 Implement search history for the brick search #4304

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Catroid-1196 Implement search history for the brick search #4304

merged 1 commit into from
Jul 18, 2022

Conversation

Walcho1125
Copy link
Contributor

@Walcho1125 Walcho1125 commented Aug 12, 2021 •
edited
Loading

Please enter a short description of your pull request and add a reference to the Jira ticket.
https://jira.catrob.at/browse/CATROID-1196
Implement search history for the brick search showing recently used search queries to the user

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@Walcho1125 Walcho1125 force-pushed the CATROID-1196 branch 3 times, most recently from 7c4fbae to a7275dc Compare August 14, 2021 06:51
Tamdav
Tamdav approved these changes Aug 14, 2021
View reviewed changes
Copy link
Contributor

@Tamdav Tamdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

wslany
wslany requested changes Aug 18, 2021
View reviewed changes
Copy link
Member

@wslany wslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests as discussed on Slack.

@Walcho1125 Walcho1125 force-pushed the CATROID-1196 branch 2 times, most recently from 114929b to 2e2998d Compare August 21, 2021 10:56
@juliajulie95
Copy link
Contributor

Please rebase

@Walcho1125 Walcho1125 force-pushed the CATROID-1196 branch 6 times, most recently from d2d60ef to 655cd9f Compare May 12, 2022 12:10
@Walcho1125 Walcho1125 force-pushed the CATROID-1196 branch 3 times, most recently from 39dadcd to c9eccec Compare June 22, 2022 13:52
@wslany wslany merged commit 694a713 into Catrobat:develop Jul 18, 2022
@wslany
Copy link
Member

wslany commented Jul 18, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wslany wslany wslany approved these changes

@Tamdav Tamdav Tamdav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Walcho1125 @juliajulie95 @wslany @Tamdav