Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CATROID-1121 Refactor MainMenuActivity and related files to Kotlin #4209

Merged
merged 1 commit into from
Aug 2, 2022
Merged

CATROID-1121 Refactor MainMenuActivity and related files to Kotlin #4209

merged 1 commit into from
Aug 2, 2022

Conversation

khushal1707
Copy link
Member

@khushal1707 khushal1707 commented Jun 8, 2021 •
edited
Loading

TIcket: https://jira.catrob.at/browse/CATROID-1121

  • Refactored MainMenuActivity, TermsOfUseDialogFragment, AboutDialogFragment to kotlin
  • Applied View Binding to above mentioned file

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@khushal1707 khushal1707 force-pushed the CATROID-1121 branch 4 times, most recently from b24f940 to deb2eab Compare June 9, 2021 11:24
@khushal1707 khushal1707 mentioned this pull request Jun 10, 2021
Merged
14 tasks
@khushal1707 khushal1707 force-pushed the CATROID-1121 branch 4 times, most recently from 557fa4b to 5b4ae41 Compare June 10, 2021 17:04
@khushal1707 khushal1707 force-pushed the CATROID-1121 branch 2 times, most recently from 783f8df to ed79129 Compare June 24, 2021 19:21
@khushal1707 khushal1707 force-pushed the CATROID-1121 branch 2 times, most recently from 00d08fc to e6df41a Compare July 14, 2021 17:24
ndrnour
ndrnour previously requested changes Jul 18, 2021
View reviewed changes
Copy link
Contributor

@ndrnour ndrnour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please consider the suggested changes in your Code.

@ndrnour
Copy link
Contributor

ndrnour commented Jul 18, 2021

also please fix this APK FAILED
21:16:04 > Task :catroid:compileStandaloneDebugKotlin 21:16:04 e: /home/catroid/jenkins_slave/workspace/Catroid_PR-4209/catroid/src/main/java/org/catrobat/catroid/ui/BaseActivity.kt: (40, 49): Unresolved reference: surveyCampaign 21:16:04 e: /home/catroid/jenkins_slave/workspace/Catroid_PR-4209/catroid/src/main/java/org/catrobat/catroid/ui/BaseActivity.kt: (97, 9): Unresolved reference: surveyCampaign 21:16:04 e: /home/catroid/jenkins_slave/workspace/Catroid_PR-4209/catroid/src/main/java/org/catrobat/catroid/ui/BaseActivity.kt: (150, 13): Unresolved reference: surveyCampaign 21:16:04 e: /home/catroid/jenkins_slave/workspace/Catroid_PR-4209/catroid/src/main/java/org/catrobat/catroid/ui/BaseActivity.kt: (151, 13): Unresolved reference: surveyCampaign 21:16:04 21:16:04 > Task :catroid:compileStandaloneDebugKotlin FAILED

@khushal1707 khushal1707 force-pushed the CATROID-1121 branch 2 times, most recently from 92be542 to fa58e33 Compare July 21, 2021 03:08
@khushal1707
Copy link
Member Author

Done!

@khushal1707 khushal1707 requested a review from ndrnour July 21, 2021 03:35
@ndrnour
Copy link
Contributor

ndrnour commented Aug 1, 2021

please keep an eye on #4286, once it gets merged, rebase and then I'll review it

bengaal
bengaal approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@bengaal bengaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Walcho1125 Walcho1125 dismissed ndrnour’s stale review August 2, 2022 14:00

Contributor is no longer part of the team, changes are already resolved

DinosaurierRex
DinosaurierRex approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@DinosaurierRex DinosaurierRex left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PO review LGTM 👍

@Walcho1125 or @juliajulie95 Please merge! Thnks

@juliajulie95 juliajulie95 merged commit 00a2865 into Catrobat:develop Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DinosaurierRex DinosaurierRex DinosaurierRex approved these changes

@bengaal bengaal bengaal approved these changes

@ndrnour ndrnour Awaiting requested review from ndrnour

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@khushal1707 @ndrnour @DinosaurierRex @bengaal @juliajulie95