-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CATROID-1078 Add new CLTs for the set transparency brick #4171
Conversation
ad9ce95
to
5fb08c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test cases (in the same testSetTransparency.catrobat test suite) to check whether the transparency is actually changing on the screen. This can be done using the color sensors, and also the touch sensors, as well as the Tap bricks. There are several ways to do this.
Please also add a test case (in the same testSetTransparency.catrobat test suite) that checks whether the brick is slowing down loops as expected (see https://jira.catrob.at/browse/CATROID-760 for details).
Please remember that the CLTs should be able to serve as a specification by example for future implementations and for Catty (which does not yet have a physics engine). |
0111b80
to
5da2b29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
requested changes are resolved, PR can be merged
https://jira.catrob.at/browse/CATROID-1078
A new CLT was created to ensure proper test coverage of this brick. After the transparency of an object has been set it can be queried and checked via the
transparency
-property to make sure that it has been set correctly. Edge cases (what happens if the transparency goes beyond 100%/below 0%) have also been tested.Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.