Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATROID-1078 Add new CLTs for the set transparency brick #4171

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

reichli
Copy link
Contributor

@reichli reichli commented Apr 30, 2021

https://jira.catrob.at/browse/CATROID-1078

A new CLT was created to ensure proper test coverage of this brick. After the transparency of an object has been set it can be queried and checked via the transparency-property to make sure that it has been set correctly. Edge cases (what happens if the transparency goes beyond 100%/below 0%) have also been tested.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@reichli reichli force-pushed the CATROID-1078 branch 2 times, most recently from ad9ce95 to 5fb08c6 Compare May 11, 2021 15:26
Copy link
Contributor

@adnaribo adnaribo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

wslany
wslany previously requested changes May 15, 2021
Copy link
Member

@wslany wslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test cases (in the same testSetTransparency.catrobat test suite) to check whether the transparency is actually changing on the screen. This can be done using the color sensors, and also the touch sensors, as well as the Tap bricks. There are several ways to do this.

Please also add a test case (in the same testSetTransparency.catrobat test suite) that checks whether the brick is slowing down loops as expected (see https://jira.catrob.at/browse/CATROID-760 for details).

@wslany
Copy link
Member

wslany commented May 15, 2021

Please remember that the CLTs should be able to serve as a specification by example for future implementations and for Catty (which does not yet have a physics engine).

Copy link
Contributor

@UlrichLa UlrichLa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mseiser mseiser dismissed wslany’s stale review February 6, 2023 21:14

requested changes are resolved, PR can be merged

@mseiser mseiser merged commit 9888bb9 into Catrobat:develop Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants