Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated textSize, paddingStart, marginStart to be consistent with most of Android UI guidelines #2327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MaddyRizvi
Copy link

Description of the Problem:

The layout for the CheckBox in the sorting_option.xml was not properly spaced, resulting in a cluttered appearance and inconsistent alignment.

Solution:

I adjusted the textSize, paddingStart, and marginStart for the CheckBox to improve its readability and visual alignment within the LinearLayout. Specifically:

  • Increased textSize to 18sp for better readability.
  • Set paddingStart and marginStart to 16dp for consistent spacing around the checkbox.

Why I Chose This Solution:

These changes adhere to common Android UI best practices, ensuring that the checkbox appears neatly aligned and readable across different screen sizes and densities.

Testing:

The changes have been tested through unit tests, static analysis (Lint, SpotBugs), and manual UI verification on a live device/emulator.

@TheLastProject
Copy link
Member

I agree it's not quite perfect, but I don't think this is really going as you intended it? I tested it on my Fairphone 3 and it looks noticeably worse and more misaligned:

Stable Your change
image image

These changes adhere to common Android UI best practices

Linking to the documentation of these best practices could help a lot btw :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants