updated textSize, paddingStart, marginStart to be consistent with most of Android UI guidelines #2327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Problem:
The layout for the
CheckBox
in thesorting_option.xml
was not properly spaced, resulting in a cluttered appearance and inconsistent alignment.Solution:
I adjusted the
textSize
,paddingStart
, andmarginStart
for theCheckBox
to improve its readability and visual alignment within theLinearLayout
. Specifically:textSize
to18sp
for better readability.paddingStart
andmarginStart
to16dp
for consistent spacing around the checkbox.Why I Chose This Solution:
These changes adhere to common Android UI best practices, ensuring that the checkbox appears neatly aligned and readable across different screen sizes and densities.
Testing:
The changes have been tested through unit tests, static analysis (Lint, SpotBugs), and manual UI verification on a live device/emulator.