-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routing network request to specific network #914
Conversation
Need clear binding when stop syncthing |
Cool, thanks for working on it :-). |
Done. but only working on SDK 23 and up |
app/src/main/java/com/nutomic/syncthingandroid/service/SyncthingRunnable.java
Show resolved
Hide resolved
app/src/main/java/com/nutomic/syncthingandroid/service/SyncthingRunnable.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nutomic/syncthingandroid/service/SyncthingRunnable.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nutomic/syncthingandroid/service/SyncthingRunnable.java
Outdated
Show resolved
Hide resolved
That's no problem. |
app/src/main/java/com/nutomic/syncthingandroid/service/SyncthingRunnable.java
Show resolved
Hide resolved
app/src/main/java/com/nutomic/syncthingandroid/service/SyncthingRunnable.java
Outdated
Show resolved
Hide resolved
I also think bindNetwork will not be executed if run conditions are changed by the user while Syncthing is running. But given that this is expected to rarely happen, mainly on initial setup, we can skip writing code for it now and if it really turns out important do it later. Plus, using mobile data is default off. |
Yeah, I agree with you. Basically, I just want make my code as simple as possible. |
Perfect. Any more testing needed? Or should I merge this as is? |
Thanks for your contribution :-). 🚀 |
I set wifi only, in the first few days, my home wifi dns broken when I don't know, but it connect.
So, syncthing is running and android system routing all the request to mobile data, and consumed my entire traffic allowance at one night.
The patch is for the situation.