Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocked texts on first welcome page (fixes #835) #836

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

EasyVector
Copy link
Contributor

Dear developer:

I am the creator of issue #835, and I have fixed the blocked texts on the first welcome page. I would appreciate it if you could kindly revise my code and leave me some advice. Thank you so much for your precious time!

Here is the screenshot after my modifications, and I made the text scrollable so I can see all of it.

copy

@Catfriend1
Copy link
Owner

Thank you very much. Will test it on my phone during next dev session and then give feedback to you.

@Catfriend1 Catfriend1 added this to the v1.18.2 milestone Aug 16, 2021
@Catfriend1 Catfriend1 added the bug label Aug 16, 2021
@Catfriend1 Catfriend1 linked an issue Aug 16, 2021 that may be closed by this pull request
@Catfriend1 Catfriend1 changed the title Hi! I have fixed the blocked texts on the first welcome page Fix blocked texts on first welcome page (fixes #835) Aug 16, 2021
@Catfriend1
Copy link
Owner

Hi @yuhuitech ,

could you please test the build of this PR using:

  • smallest font size
  • default font size
  • largest font size
    on your phone and send me some screenshots to review, please?

Thank you.

https://github.com/Catfriend1/syncthing-android/releases/download/v1.18.1.0%2B59b9fd3c/com.github.catfriend1.syncthingandroid_github_v1.18.1.0+59b9fd3c.apk

@EasyVector
Copy link
Contributor Author

OK, I will work on this :)

@Catfriend1
Copy link
Owner

It's okay, I made a fast attempt to do this on the emulator. Lgtm. Thank you very much again for contributing to Syncthing Fork :-). You're welcome.

@Catfriend1 Catfriend1 merged commit aa2bff7 into Catfriend1:main Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A part of texts could not be seen fully on the first welcome page
2 participants