Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable wakelock experimental option on Android 6+ #77

Merged
merged 1 commit into from
Oct 7, 2018

Conversation

Catfriend1
Copy link
Owner

Purpose
Disable wakelock experimental option on Android 6+ as it's no longer valid for recent Android OS versions. Android Doze forcefully cancels wakelocks so setting them proved to be of no use.

Testing
Verified working on Xiaomi Mi8 running Android 8.1.0.
Issue that wakelocks don't help when the connection cannot be made during screen off periods was confirmed on Huawei P10 running Android 8.1.0.

@Catfriend1 Catfriend1 added the bug label Oct 7, 2018
@Catfriend1 Catfriend1 added this to the 0.14.52 milestone Oct 7, 2018
@Catfriend1 Catfriend1 self-assigned this Oct 7, 2018
@Catfriend1
Copy link
Owner Author

@Review/Complete.
lgtm.

@Catfriend1 Catfriend1 merged commit 2021ef6 into master Oct 7, 2018
@Catfriend1 Catfriend1 deleted the 20181007-hideWakeLockForAndroid6plus branch October 7, 2018 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant