possible fix for 'Could not determine app's private files directory'

[balihb]

#759
the possible fix I proposed for the issue. this solution won't remove the first element from the list, but instead choose the 2nd one if there is more than one.

[balihb]

@Catfriend1 is it possible to maybe push this change to the Play Store beta, so I can test if it works? Or how should we step forward?

[Catfriend1]

Hi,

I'm a little bit busy and behind atm, ir it's just testing you can use the compile scripts from this repo to make your own debut build easily without signing stuff or I could do an APK build for you.

I hope to have some free time available for the fork next week.

Meanwhilst, thanks for you help on this, much appreciated :-)!

[Catfriend1]

Memo for me: Look up why we changed the path detection in the past (remember crashes? issues with phone manufacturer stock os'es?) There was a ticket, not that we reintroduce the probleme again for others.

[Catfriend1]

Ah yes , I should do something here when time allows, still noted!

[Catfriend1]

Merged into "beta" branch.

[Catfriend1]

AVD 11:

[Catfriend1]

Problem: After this PR it does not save the emergency export to internal storage.

Request: As it was the result before this PR, Syncthing-Fork should export its private keys and config to the phone's internal storage. This may be some path like /storage/ABCD-EFGH/Android/media/[pkg_id] or /storage/emulated/0/Android/media/[pkg_id] . Syncthing-Fork should detect the internal storage's absolute path correctly and export to it.

Next steps to take @balihb : Please show me which File URIs or absolute paths your phone/Android OS returns for

getExternalMediaDirs()

so we can work out a solution not breaking the existing behaviour on other phones implementations, Android versions and the Android emulator.

INTERNAL STORAGE:

EXTERNAL SD CARD STORAGE:

[Catfriend1]

.

[Catfriend1]

@balihb Something maybe is wrong what I've stated above. Let's do a test build ( https://drive.google.com/file/d/1FVLHSkIamwFNrhQGOLBj2qNz8Jnqh2KV/view?usp=sharing ) . Could you please check if this build fixes the problem on your phone you've originally had?

[balihb]

@balihb Something maybe is wrong what I've stated above. Let's do a test build ( https://drive.google.com/file/d/1FVLHSkIamwFNrhQGOLBj2qNz8Jnqh2KV/view?usp=sharing ) . Could you please check if this build fixes the problem on your phone you've originally had?

with this I could grant all file access, but I didn't and I pressed the emergency button. gave me the same failure.

[balihb]

Failed to export config
java.io.FileNotFoundException: /data/user/0/com.github.catfriend1.syncthingandroid.debug/files/config.xml: open failed: ENOENT (No such file or directory)
at libcore.io.IoBridge.open(IoBridge.java:492)
at java.io.FileInputStream.(FileInputStream.java:160)
at com.google.common.io.Files$FileByteSource.openStream(Files.java:130)
at com.google.common.io.Files$FileByteSource.openStream(Files.java:120)
at com.google.common.io.ByteSource.copyTo(ByteSource.java:264)
at com.google.common.io.Files.copy(Files.java:326)
at com.nutomic.syncthingandroid.activities.FirstStartActivity.exportConfig(FirstStartActivity.java:778)
at com.nutomic.syncthingandroid.activities.FirstStartActivity.access$400(FirstStartActivity.java:54)
at com.nutomic.syncthingandroid.activities.FirstStartActivity$ViewPagerAdapter$1.onClick(FirstStartActivity.java:410)
at android.view.View.performClick(View.java:7496)
at android.view.View.performClickInternal(View.java:7473)
at android.view.View.access$3600(View.java:831)
at android.view.View$PerformClick.run(View.java:28641)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:236)
at android.app.ActivityThread.main(ActivityThread.java:7876)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:656)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:967)
Caused by: android.system.ErrnoException: open failed: ENOENT (No such file or directory)
at libcore.io.Linux.open(Native Method)
at libcore.io.ForwardingOs.open(ForwardingOs.java:166)
at libcore.io.BlockGuardOs.open(BlockGuardOs.java:254)
at libcore.io.ForwardingOs.open(ForwardingOs.java:166)
at android.app.ActivityThread$AndroidOs.open(ActivityThread.java:7762)
at libcore.io.IoBridge.open(IoBridge.java:478)
... 19 more

[Catfriend1]

@balihb Did you configure Syncthing first before revoking all files permission and trying the emergency export?

[Catfriend1]

We should maybe add the extra code which displays an error more clear if Syncthing has nothing to export when it was'nt configured.

[Catfriend1]

I'm closing this. Later to be re-opened, when we know what needs exactly to be fixed and how.

[Catfriend1]

Bug on some devices: #541