Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround cleanup of the folder marker by Huawei, Xiaomi firmware (fixes #131) #363

Merged
merged 9 commits into from
Mar 11, 2019

Conversation

Catfriend1
Copy link
Owner

@Catfriend1 Catfriend1 commented Mar 10, 2019

Purpose:

Testing:

  • Verified doing technically the right thing on AVD 9.x at commit 99e1659 .
  • Needs community test.

@Catfriend1 Catfriend1 self-assigned this Mar 10, 2019
@Catfriend1 Catfriend1 changed the title Fix cleanup of the folder marker by Huawei firmware Fix cleanup of the folder marker by Huawei, Xiaomi firmware Mar 10, 2019
@Catfriend1 Catfriend1 changed the title Fix cleanup of the folder marker by Huawei, Xiaomi firmware Workaround cleanup of the folder marker by Huawei, Xiaomi firmware Mar 10, 2019
@Catfriend1 Catfriend1 added this to the 1.1.1 milestone Mar 10, 2019
@Catfriend1
Copy link
Owner Author

@Review/Complete
lgtm.

@Catfriend1 Catfriend1 added the testing Community test case - Notice: Consists of maybe unstable syncthing version or code label Mar 10, 2019
@Catfriend1
Copy link
Owner Author

Anyone having the same issue reading this? I've put up a test APK at https://drive.google.com/open?id=1FyPl16VXL6WAjuazSDIBtaN79ZRCTX0o and would appreciate feedback if this works correctly after adding a new folder and running the phone's file cleanup utility. The workaround adds a dummy text file below the ".stfolder" directory.

@otbutz
Copy link

otbutz commented Mar 10, 2019

@Catfriend1 i don't have a phone which is affected but it might be worth to run a public beta test on the PlayStore for things like this

@GottZ
Copy link

GottZ commented Mar 11, 2019

what about already existing sync folders where the .stfolder has been deleted already?
i doubt users know what to do when they see the "folder marker missing" error.

@GottZ
Copy link

GottZ commented Mar 11, 2019

hereby confirm this works on my Huawei Mate 10 Pro

@Catfriend1
Copy link
Owner Author

Thanks for reporting back. Already missing markers have to be restored manually as it would circumvent the safety meaning of why the marker exists when we would recreate it automatically.

@Catfriend1 Catfriend1 changed the title Workaround cleanup of the folder marker by Huawei, Xiaomi firmware Workaround cleanup of the folder marker by Huawei, Xiaomi firmware (fixes #131) Mar 11, 2019
@Catfriend1 Catfriend1 merged commit 7a12674 into master Mar 11, 2019
@Catfriend1 Catfriend1 deleted the 20181129-fixIssue131 branch March 11, 2019 14:42
@Catfriend1 Catfriend1 removed the testing Community test case - Notice: Consists of maybe unstable syncthing version or code label Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create .stfolder and DO_NOT_DELETE.txt within it to prevent automatic cleanup of empty directories
3 participants