-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuring time schedule interval #1168
Conversation
Thank you 😊. Cool, that came unexpected but I welcome your work on this 👍. I'll have a look during one of the next dev sessions. |
app/src/main/java/com/nutomic/syncthingandroid/activities/SettingsActivity.java
Outdated
Show resolved
Hide resolved
@ImranR98 Do you have a test APK at hand I could try this out easily? |
Sure. GitHub isn't letting me upload files >25MB. |
Hey, just checking in - is there anything else needed for this PR? |
All fine, I just need to take time to do a next dev session. :) |
Not sure I make it before christmas... but it's still on my todo list to give this a release as well. 1.28.1 is also coming in :)... . Or we'll do community testing if 1.28.0 is not urgently broken and see what the feedback is. This would save my time a lot to label this as included in a 1.28.1-preview . |
@ImranR98 I've read through the code and noticed the "mSyncIntervalMinutes". Could we please rename it to "mSleepIntervalMinutes", according to the PREF's name? |
Done |
Thank you very much 🙏 |
Checked again, I'd rename this as well after merging to say sleep_..... sync_interval_minutes |
Renamed |
Thanks again for caring :-). Ich have little time at the moment just because it's before christmas. 🎄 You are welcome to help the project and pls tell me if you need something. |
Will do |
Resolves #960