Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typo Github to GitHub #1103

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Conversation

acolomb
Copy link
Contributor

@acolomb acolomb commented Mar 23, 2024

Apply essentially the same change as in upstream, to reduce diff:
syncthing/syncthing-android#2070

Apply essentially the same change as in upstream, to reduce diff:
syncthing/syncthing-android#2070
@Catfriend1 Catfriend1 merged commit 63a4ea6 into Catfriend1:main Mar 23, 2024
@Catfriend1
Copy link
Owner

Thanks :)

@acolomb acolomb deleted the fork/typo-github branch March 23, 2024 17:14
@Catfriend1
Copy link
Owner

Catfriend1 commented Oct 31, 2024

@acolomb

Hi,

could you please have a look at the following issue? I've corrected the following mistake via Weblate site manually multiple times, but short time after, the weblate commits back the wrong old string definition which causes the build to fail. Why does it do that?

image

image

The red string is the correct one I've set & saved via Weblate.

Thank you.

Kind regards,
Catfriend1

@acolomb
Copy link
Contributor Author

acolomb commented Oct 31, 2024

Looks like some user named 109247019824 is playing a game of back-and-forth with you:

https://hosted.weblate.org/translate/syncthing/android/catfriend1/fork-stringsxml/bg/?checksum=6092e2942b982bf2&q=context%3A%3Ddevice_syncing+&sort_by=-priority%2Cposition#history

I guess the intention is to put a space between the number and the percent sign. But instead the change breaks the escape sequence that is necessary to achieve a literal percent sign in the string. The space should be added so that both percent signs are behind it. As it is done in the German translation for example (which is correct typography there).

And it should probably be a non-breaking space (NBS in Weblate).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants