Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync percentage (device) not accurate if local folder paused #463

Closed
Catfriend1 opened this issue Aug 13, 2019 · 1 comment · Fixed by #470
Closed

Sync percentage (device) not accurate if local folder paused #463

Catfriend1 opened this issue Aug 13, 2019 · 1 comment · Fixed by #470
Assignees
@Catfriend1
Labels
bug
Milestone
1.2.2

Comments

@Catfriend1
Copy link
Owner

Catfriend1 commented Aug 13, 2019 •
edited
Loading

Description of the issue

Sync percentage (device) not accurate if local folder paused

Reproducer:

  • Add two folders shared with the same device
  • Let them complete sync
  • Pause folder1 on mobile phone
  • Add a file to folder2 on the other side, let it sync

Symptom:

  • Phone shows:
    image
    image

  • PC shows:
    image
@Catfriend1 Catfriend1 added the bug label Aug 13, 2019
@Catfriend1 Catfriend1 added this to the 1.2.1 milestone Aug 13, 2019
@Catfriend1 Catfriend1 self-assigned this Aug 13, 2019
@Catfriend1 Catfriend1 modified the milestones: 1.2.1, 1.2.2 Aug 15, 2019
@Catfriend1
Copy link
Owner Author

Made some debugging:

2019-08-17 18:02:07.716 7120-7120/com.github.catfriend1.syncthingandroid.debug V/Completion: setCompletionInfo: Storing 0.0% for folder "lvj5r-kpqgs".
2019-08-17 18:02:07.720 7120-7120/com.github.catfriend1.syncthingandroid.debug V/Completion: setCompletionInfo: Storing 100.0% for folder "prprh-zhbeq".

Solution: We need to assume paused folders as "completion = 100%"

Catfriend1 added a commit that referenced this issue Aug 17, 2019
@Catfriend1
Fix device sync percentage calculation for paused folders (fixes #463)
f40ab80
@Catfriend1 Catfriend1 mentioned this issue Aug 17, 2019
Merged
Catfriend1 pushed a commit that referenced this issue Aug 17, 2019
Fix device sync percentage calculation for paused folders (fixes #463)…
8d47d43 
… (#470)

* model/CompletionInfo: Cleanup comment

* Fix device sync percentage calculation for paused folders (fixes #463)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Catfriend1 Catfriend1

Labels
bug
Projects
None yet
Milestone
1.2.2
Development

Successfully merging a pull request may close this issue.

Fix device sync percentage calculation for paused folders (fixes #463) Catfriend1/syncthing-android
1 participant
@Catfriend1