Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android TV: Better visual indication of hamburger menu hovered state #244

Closed
Catfriend1 opened this issue Jan 19, 2019 · 1 comment · Fixed by #246
Closed

Android TV: Better visual indication of hamburger menu hovered state #244

Catfriend1 opened this issue Jan 19, 2019 · 1 comment · Fixed by #246
Assignees
@Catfriend1
Labels
bug
Milestone
1.0.1

Comments

@Catfriend1
Copy link
Owner

Catfriend1 commented Jan 19, 2019 •
edited
Loading

Reported by @o-l-a-v in #194:

Description of the issue

The lighter blue when hovering an icon is not that much different from the regular blue. Too little contrast to be easy to see. Thought I lost the dpad when In fact I was hovering the hamburger menu. The contrast is barely noticable on the hamburger menu actually, much worse than the rest of the UI.

image
@Catfriend1 Catfriend1 added the bug label Jan 19, 2019
Catfriend1 added a commit that referenced this issue Jan 19, 2019
@Catfriend1
Add drawables: menu white, black; settings_black (fixes #243) (fixes #…
1cb824d 
…244)
@Catfriend1 Catfriend1 mentioned this issue Jan 19, 2019
Merged
@Catfriend1 Catfriend1 self-assigned this Jan 19, 2019
@Catfriend1 Catfriend1 added this to the 1.0.1 milestone Jan 19, 2019
Catfriend1 added a commit that referenced this issue Jan 19, 2019
@Catfriend1
WIP: Try to fix issue #244
37612f0
Catfriend1 added a commit that referenced this issue Jan 19, 2019
@Catfriend1
WIP: Try to fix issue #244 (2)
f2e5702
Catfriend1 added a commit that referenced this issue Jan 19, 2019
@Catfriend1
WIP: Try to fix issue #244 (3)
09e9841
@Catfriend1
Copy link
Owner Author

The fix will be part of an upcoming release.

Catfriend1 pushed a commit that referenced this issue Jan 19, 2019
Improve visual hover indication on Android TVs (#246)
d16ba49 
* Add drawables: menu white, black; settings_black (fixes #243) (fixes #244)

* Add drawable: button arrow_back

* Add button desc strings: open/close menu

* WIP: Try to fix issue #244

* WIP: Try to fix issue #244 (2)

* WIP: Try to fix issue #244 (3)

* Fix lint

* Add visual indication when hovering share icon in "Show Device ID" dialog (fixes #242)

* Updated de translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Catfriend1 Catfriend1

Labels
bug
Projects
None yet
Milestone
1.0.1
Development

Successfully merging a pull request may close this issue.

Improve visual hover indication on Android TVs Catfriend1/syncthing-android
1 participant
@Catfriend1