Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

Removing TODOs and simplifying deploymenttable.ts #527

Merged
merged 12 commits into from
Apr 9, 2020

Conversation

samiyaakhtar
Copy link
Collaborator

@andrebriggs andrebriggs requested a review from dennisseah April 8, 2020 01:15
Copy link
Collaborator

@andrebriggs andrebriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending sync to discuss this area

@samiyaakhtar samiyaakhtar changed the title Removing TODOs in deploymenttable.ts Removing TODOs and simplifying deploymenttable.ts Apr 8, 2020
Copy link
Collaborator

@mtarng mtarng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we can probably also remove /* eslint-disable @typescript-eslint/no-use-before-define */ from deploymenttable.ts at this time.

@samiyaakhtar samiyaakhtar requested a review from andrebriggs April 9, 2020 02:24
@samiyaakhtar samiyaakhtar merged commit b8df195 into CatalystCode:master Apr 9, 2020
@samiyaakhtar samiyaakhtar deleted the 1301 branch April 9, 2020 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor deploymenttable.ts logic in CLI
6 participants