This repository was archived by the owner on Apr 13, 2020. It is now read-only.
Support for relative paths Design Doc in SPK #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
NathanielRose
commented
Mar 26, 2020
NathanielRose
commented
- Closes: [Design] SPK Generate can not locate relative template paths of a terraform module when the source provider is local to the repo microsoft/bedrock#1194
- Related to: [WIP] Adjusting modules to relative paths microsoft/bedrock#1189
- Related to Bedrock TF template modules should use relative paths microsoft/bedrock#996
- Implementation User Story: [SPK] As an SRE I want to be able to use SPK with modules referenced by relative path microsoft/bedrock#1149
NathanielRose
requested review from
jmspring,
sarath-p,
andrebriggs,
dennisseah and
yradsmikham
NathanielRose
force-pushed
the
nate.design.relativepaths
branch
from
5e73b9f to
fd79f7b
Compare
andrebriggs
suggested changes
Mar 26, 2020
andrebriggs
approved these changes
Mar 26, 2020
dennisseah
approved these changes
Mar 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.