Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

Append variable group to manifest-generation.yaml #453

Merged
merged 14 commits into from
Mar 27, 2020
Merged

Append variable group to manifest-generation.yaml #453

merged 14 commits into from
Mar 27, 2020

Conversation

edaena
Copy link
Contributor

@edaena edaena commented Mar 26, 2020 •
edited
Loading

Resolves issue

dennisseah
dennisseah suggested changes Mar 26, 2020
View reviewed changes
Copy link
Collaborator

@dennisseah dennisseah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please a unit test for append-variable-group.ts thanks

@edaena edaena changed the title [Do not merge] - Append variable group to manifest-generation.yaml Append variable group to manifest-generation.yaml Mar 26, 2020
sarath-p
sarath-p approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@sarath-p sarath-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samiyaakhtar
Copy link
Collaborator

Should we be updating some walkthroughs to remind users to run this command for full end-end introspection experience?

@edaena
Copy link
Contributor Author

edaena commented Mar 27, 2020

@samiyaakhtar I'll update the walkthrough in the bedrock repository.

@mtarng mtarng merged commit 9e4b663 into master Mar 27, 2020
@edaena edaena deleted the edaena-vg branch April 1, 2020 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtarng mtarng mtarng left review comments

@samiyaakhtar samiyaakhtar samiyaakhtar approved these changes

@dennisseah dennisseah dennisseah approved these changes

@evanlouie evanlouie Awaiting requested review from evanlouie

@andrebriggs andrebriggs Awaiting requested review from andrebriggs

@sarath-p sarath-p Awaiting requested review from sarath-p

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manifest generation pipeline should support optional variable group
5 participants
@edaena @samiyaakhtar @sarath-p @dennisseah @mtarng