Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

[DOC-FIX] remove CORS setting requirement #443

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Conversation

dennisseah
Copy link
Collaborator

No description provided.

@edaena
Copy link
Contributor

edaena commented Mar 24, 2020

@dennisseah Why is this requirement removed?

@dennisseah
Copy link
Collaborator Author

@dennisseah Why is this requirement removed?

We implemented the backend for dashboard and CORS settings are not needed. @samiyaakhtar can you confirm. Generally setting CORS for localhost is not good things (w.r.t. security)

@samiyaakhtar
Copy link
Collaborator

@dennisseah @edaena shouldn't be needed anymore if people are using the new docker image hopefully, that queries APIs from a backend instead. I guess we can remove it since we've already updated the image

@edaena
Copy link
Contributor

edaena commented Mar 24, 2020

@samiyaakhtar @dennisseah do we need to also remove enabling CORS in the storage account in the integration tests?

@samiyaakhtar
Copy link
Collaborator

@edaena Agreed, maybe we should get rid of that snippet of code from integration tests as well. Might be worth closing out in one PR. @dennisseah could we remove the part from rings integration test which adds CORS setting to the storage account?

@dennisseah
Copy link
Collaborator Author

@edaena Agreed, maybe we should get rid of that snippet of code from integration tests as well. Might be worth closing out in one PR. @dennisseah could we remove the part from rings integration test which adds CORS setting to the storage account?

can someone do it? or tell me where is it if you want me to remove it :-)

@dennisseah dennisseah closed this Mar 24, 2020
@dennisseah dennisseah reopened this Mar 24, 2020
@dennisseah dennisseah merged commit cb16c22 into master Mar 24, 2020
@samiyaakhtar
Copy link
Collaborator

@dennisseah it had to be done before the PR was merged :( I'll open another PR for this.

@dennisseah dennisseah deleted the fixOnboardDashboardDoc branch March 25, 2020 02:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants