This repository was archived by the owner on Apr 13, 2020. It is now read-only.
Adds version number and message to Bedrock.yaml #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisseah
reviewed
Mar 19, 2020
There was a problem hiding this comment.
we have version: "1.0" in many places in test files. So, we have to update all of them whenever version number changes. am I right? Can we get the version by calling the getVersion function to avoid having to update test? Other thing, the getVersion function get the version from package.json every time, can we cache it?
|
Regarding "1.0", it is a test data and not dependent on the actual on version number. We can implement caching but frequency of calling this method is very low since we it is only used in |
|
ok. "1.0" is coming for mocked. |
dennisseah
approved these changes
Mar 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes microsoft/bedrock#1082