[FEATURE] scaffold app and helm repo in spk setup command #398
Conversation
dennisseah
requested review from
sarath-p,
mtarng,
andrebriggs,
edaena and
samiyaakhtar
|
@dennisseah looks good. We might want to look at #402 first |
Thanks for helping @andrebriggs issue1113x is based on issue1113. That's issue1113x has more changes (to create the lifecycle and build pipelines that branch issue1113 does not have). I cannot create PR for issue1113x branch until this one is merge, otherwise the PR will be huge. Thanks |
| @@ -150,6 +176,7 @@ export const prompt = async (): Promise<RequestContext> => { | |||
|
|
|||
There was a problem hiding this comment.
Line 163 or prompt.ts
message: Do you like create a sample application repository?, should be
message: Would you like to create a sample application repository?,
| @@ -76,6 +86,9 @@ describe("test prompt function", () => { | |||
| az_sp_password: "a510c1ff-358c-4ed4-96c8-eb23f42bbc5b", | |||
| az_sp_tenant: "72f988bf-86f1-41af-91ab-2d7cd011db47" | |||
| }); | |||
| jest.spyOn(inquirer, "prompt").mockResolvedValueOnce({ | |||
| acr_name: "testACR" | |||
| }); | |||
| jest.spyOn(subscriptionService, "getSubscriptions").mockResolvedValueOnce([ | |||
There was a problem hiding this comment.
In one case, I attempt to create a service principal with the az command line after logging in. I received an error getting a token request due to an unauthorized client. This may have occurred because I may have sent your authentication request to the wrong tenant. In any case, we should add an additional safety net to select the appropriate subscription ID after login to create the service principal in.
There was a problem hiding this comment.
can you please elaborate on this? Do you want to select subscription Id first and then create service principal? Currently, we are doing the other way around, we can service principal and automatically figure out subscription id
There was a problem hiding this comment.
Here's the error I'm getting:
After az login the service principal gets created under the wrong tenant I believe when I select to generate a SP
error: Error: Get Token request returned http error: 400 and server response: {"error":"unauthorized_client","error_description":"AADSTS700016: Application with identifier '#' was not found in the directory '#'. This can happen if the application has not been installed by the administrator of the tenant or consented to by any user in the tenant. You may have sent your authentication request to the wrong tenant.\r\nTrace ID:#\r\nCorrelation ID: #r\nTimestamp: 2020-03-17 18:35:28Z","error_codes":[700016],"timestamp":"2020-03-17 18:35:28Z","trace_id":"#","correlation_id":"#","error_uri":"https://login.microsoftonline.com/error?code=700016"}
There was a problem hiding this comment.
@andrebriggs how can this happen. We automatically create a service principal (which has Contributor role). How can service principal being created in the wrong tenant?
There was a problem hiding this comment.
@NathanielRose let's save this behavior for another PR. Good catch though
closes microsoft/bedrock#1113