Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to download all GC links #82

Closed
therobbiedavis opened this issue Jul 28, 2023 · 2 comments
Closed

Failing to download all GC links #82

therobbiedavis opened this issue Jul 28, 2023 · 2 comments
Labels
bug Report of something not working as expected

Comments

@therobbiedavis
Copy link

Description of the bug
Kapowarr does not download all links from getcomics, just the first found

To Reproduce

  1. Add the volume in Kapowarr "Batman (1940) Volume 1"
  2. Click on "Search Monitored"
  3. See that Kapowarr finds "https://getcomics.org/dc/batman-vol-1-0-713-annuals-extras-1940-2011/"
  4. See that Kapowarr only downloads "Batman 000 – 010 (1940-1942 + 1994) (599 MB)"

Expected behaviour
I would expect in a case like this, which GC often splits up larger collections like this, that Kapowarr would iterate over the links and download then all.

Version info
v1.0.0-beta-2
Docker, Chrome

@therobbiedavis therobbiedavis added the bug Report of something not working as expected label Jul 28, 2023
@Casvt Casvt moved this to In Progress in Kapowarr plans Jul 28, 2023
@Casvt
Copy link
Owner

Casvt commented Jul 28, 2023

I would expect in a case like this, which GC often splits up larger collections like this, that Kapowarr would iterate over the links and download then all.

Kapowarr normally does this. The problem seems to be that the years don't match with the volume release year except for the first download. Kapowarr should check if the years mentioned are between release year and the year of the last issue instead of just the release year. In beta-1, the year wasn't checked at all but I added a check in beta-2. I just forgot that the year check should span the whole volume lifetime instead of just the release year.

@Casvt Casvt moved this from In Progress to In Testing in Kapowarr plans Jul 28, 2023
@Casvt
Copy link
Owner

Casvt commented Jul 28, 2023

Fixed. This fix will be included in the next release. I'll fasten beta-3 seeing that this bug has quite the impact on the workings of Kapowarr.

@Casvt Casvt closed this as completed Jul 28, 2023
@github-project-automation github-project-automation bot moved this from In Testing to Done in Kapowarr plans Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of something not working as expected
Projects
Archived in project
Development

No branches or pull requests

2 participants