Skip to content

Add support for x_forwarded_for #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Berserkir-Wolf opened this issue Jul 24, 2023 · 2 comments
Closed

Add support for x_forwarded_for #80

Berserkir-Wolf opened this issue Jul 24, 2023 · 2 comments
Labels
enhancement Request for a feature or improvement

Comments

@Berserkir-Wolf
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
When using a reverse proxy, kapowarr logs all requests as coming from the proxy.
2023-07-24T04:29:16.314292000Z [2023-07-24 16:29:16][waitress-0][INFO] Login attempt successful from 192.168.10.21

Describe the solution you'd like
I'd like an option in settings to enable reverse proxy support.
Enabling this could then activate the option for a baseurl (since that's pretty much the only reason to use one), and set the server process to listen for the x_forwarded_for header, which would pass information through so that the log would show the login attempt source correctly (provided the proxy is setting it correctly).

@Berserkir-Wolf Berserkir-Wolf added the enhancement Request for a feature or improvement label Jul 24, 2023
@Casvt Casvt moved this to Todo in Kapowarr plans Jul 24, 2023
@Casvt Casvt moved this from Todo to In Progress in Kapowarr plans Jul 24, 2023
@Casvt
Copy link
Owner

Casvt commented Jul 24, 2023

I've never used proxies so I don't have much experience with them (I barely know how they even work). Searching StackOverflow, all solutions search for the HTTP_X_FORWARDED_FOR header. Is that the same as the X_FORWARDED_FOR header you give? Or would I need to check for both headers? How many "variances" are there of this header that I should be searching for?

@Berserkir-Wolf
Copy link
Collaborator Author

HTTP_X_FORWARDED_FOR is the proper name for it - should be using that.

Casvt added a commit that referenced this issue Jul 25, 2023
@Casvt Casvt closed this as completed Jul 25, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kapowarr plans Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for a feature or improvement
Projects
Archived in project
Development

No branches or pull requests

2 participants