Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: App thinks covers are for TPBs, marking them as downloaded #69

Closed
Serneum opened this issue Jul 14, 2023 · 1 comment
Closed

Bug: App thinks covers are for TPBs, marking them as downloaded #69

Serneum opened this issue Jul 14, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Serneum
Copy link

Serneum commented Jul 14, 2023

Description of the bug

When importing an existing library that stored the series covers as a JPG file, Kapowarr seems to think that it has downloaded some comics.

As an example, I have Venom: Lethal Protector II (2023) and NewThink (2022) downloaded. For Venom, I have no issues downloaded, but have a cover.jpg and Kapowarr thinks that I have the TPB downloaded so I have all five issues. For NewThink, I have four of the five issues downloaded and a cover.jpg file. Kapowarr shows all five issues as downloaded because it thinks the cover.jpg is a TPB

To Reproduce

  1. Add a new volume
  2. Map a comic volume to a volume directory on your machine
  3. Add a JPG file to the volume directory
  4. Refresh and scan the volume the directory

Expected behaviour

Kapowarr should ignore the jpg file and not treat it like a TPB

Screenshots
image
image

image
image

Version info
Kapowarr version: v1.0.0-beta-1
Python version: 3.8.16.final.0
DB version: 6
Database location: /app/db/Kapowarr.db
Data folder: /app

Running in Docker via Docker Compose

@Serneum Serneum added the bug Something isn't working label Jul 14, 2023
@Casvt Casvt moved this to Todo in Kapowarr plans Jul 14, 2023
@Casvt Casvt moved this from Todo to Handled Soon in Kapowarr plans Jul 14, 2023
@Casvt Casvt moved this from Handled Soon to In Progress in Kapowarr plans Jul 23, 2023
Casvt added a commit that referenced this issue Jul 23, 2023
The regex to extract the page number was applied to the complete filepath. If there was a year anywhere in the filepath, it would be extract and seen as the page number. That is fixed now by only looking at the filename instead of the complete filepath.
@Casvt Casvt moved this from In Progress to In Testing in Kapowarr plans Jul 23, 2023
Casvt added a commit that referenced this issue Jul 23, 2023
@Casvt
Copy link
Owner

Casvt commented Jul 23, 2023

For now, cover files are just completely ignored. They wont be registered in Kapowarr and it will just leave them alone. This fixes your problem. It is, however, not the best approach.

This has to do with renaming mostly. If the volume folder is renamed (the volume folder regex is changed or a custom folder is set), or the root folder is changed, the cover file won't be moved/renamed. It doesn't exist to Kapowarr, so it also doesn't do anything with it. The cover file will be left behind.

It can be seen as a file that can't really be mapped to any issue and also shouldn't be named like one; it's more of a "volume file" than an "issue file".

Something similar will happen when support for metadata export is added. Metadata files will be generated for volumes. These files also don't map to any specific issue but rather map to the volume in general. This makes it exactly the same type of file like the cover file.

I should add internal support for "volume files": files that concern the volume in general and should be moved alongside the rest, but should not be mapped or renamed to a specific set of issues. I'll make an issue for it.

@Casvt Casvt closed this as completed Jul 23, 2023
@github-project-automation github-project-automation bot moved this from In Testing to Done in Kapowarr plans Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants